feat(api): multi-stage Dockerfile for gRPC API crate#29
Merged
Conversation
Depo-dev
force-pushed
the
feat/issue-13-grpc-api-dockerfile
branch
from
3171091 to
b68f3fb
Compare
…ild job Multi-stage build: rust:1.78-slim builder installs protoc, compiles trident-api in release mode with dependency caching; debian:bookworm-slim runtime copies only the binary and runs as non-root trident user on port 50051. Extends the CI docker-build job to also build the gRPC API image using GitHub Actions layer cache.
… Docker builder sqlx uses runtime-tokio-native-tls which links against OpenSSL. protoc-bin-vendored supplies its own protoc binary so the system protobuf-compiler package is not needed.
Transitive deps (home 0.5.12, icu_collections 2.2.0) require rustc 1.88; rust:1.85-slim no longer satisfies MSRV. The indexer Dockerfile lives on feat/issue-9-indexer-dockerfile, not this branch, so the Build indexer image step would always fail with file-not-found.
After the dep-caching step removes crates/indexer/src, cargo fails to resolve the workspace manifest for the indexer member on the second build pass. Recreating a minimal dummy main.rs satisfies the workspace.
feat/issue-9-indexer-dockerfile was merged into dev, so crates/indexer/Dockerfile now exists. The earlier commit that dropped this step pre-dated the merge; add it back so all three images are built in CI.
Depo-dev
force-pushed
the
feat/issue-13-grpc-api-dockerfile
branch
from
025770b to
17012a2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Dockerfileatcrates/api/Dockerfile:rust:1.78-slimbuilder (withprotocfor tonic-build) +debian:bookworm-slimruntimeproto/and source copied after the dummy-source dep buildtridentuser, exposes port 50051docker-buildjob to also buildtrident-api:ciTest plan
docker build -f crates/api/Dockerfile .succeeds locallydocker-buildjob passes on this PRCloses #13